Setup package #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorSanh
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
lgtm!
Worth reflecting the requirements in the setup.py in case someone installs directly the repo from outside.
We had the same discussion on promptsource: bigscience-workshop/promptsource#711
|
Yeah actually, I'm pushing to remove FYI I think we can always reassess later on + the README currently explains clearly the steps to install the repo. So I'm merging for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promptsource.seqio_tasksto https://github.com/bigscience-workshop/t-zero promptsource#703We'll move folders incrementally in the package, which is why they are not in this PR.