board.biomarker -> plotModule refactor #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to new plotModule format
ESCRI11
previously requested changes
Jan 12, 2023
ESCRI11
requested changes
Jan 12, 2023
There was a problem hiding this comment.
Fantastic work. Just a couple of thing left to do.
- Please add the big
ibutton on the top of the board (picture attached for reference)
To do so, please take a look at the board.dataview server / ui
In this particular board, there is no prior text for this box. Again, following board.dataview I would use this text
@ivokwee Maybe you can provide something better?
- Move the
(a)...(b)...text box to the bottom without any additional description of the board
…ures; styled all files
|
Thanks! Completed these two things + some more. There was actually prior text for this box so I used that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split the 4 plots from board.biomarker into separate files and converted them to new plotModule format. All seem to be working for me. They are just base plots.