Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA scraper #324

Merged
merged 12 commits into from
Jan 21, 2022
Merged

Add GA scraper #324

merged 12 commits into from
Jan 21, 2022

Conversation

chriszs
Copy link
Contributor

@chriszs chriszs commented Jan 20, 2022

Adds a scaper for Georgia WARN Act data.

Steps to test

python -m warn.cli GA -l DEBUG

Should create exports/ga.csv

Closes #63

Copy link
Contributor

@palewire palewire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you for stepping up and taking on an important state!

One thing we're trying to be more consistent about is saving all of the raw files we gather into the cache, before any manipulation happens. Would you mind adding that to your submission?

Earlier this morning I added a simple example that I think will work for you to the docs.

@chriszs
Copy link
Contributor Author

chriszs commented Jan 21, 2022

Okay. Now writes files to cache, reads prior years from cache.

@chriszs chriszs requested a review from palewire January 21, 2022 10:10
Copy link
Contributor

@palewire palewire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diving in on the cache, @chriszs! I've raised a few minor issues next. Let me know what you think about them.

I think we might be ready for @zstumgoren to weigh in.

warn/scrapers/ga.py Outdated Show resolved Hide resolved
warn/scrapers/ga.py Outdated Show resolved Hide resolved
warn/scrapers/ga.py Outdated Show resolved Hide resolved
warn/scrapers/ga.py Outdated Show resolved Hide resolved
@palewire palewire requested a review from zstumgoren January 21, 2022 12:38
@chriszs chriszs requested a review from palewire January 21, 2022 16:42
@zstumgoren
Copy link
Member

At a glance, this looks fantastic! Thanks for adding in the caching behavior @chriszs !!

Looks ready to merge if @palewire agrees. Somewhat related, but I'd like for us to hash out and formalize our caching policy in a new issue. I've been mulling some ideas about different caches approach in various situations, but some of the questions are more editorial judgement-y than technical. Wouldn't mind having us discuss as a group. 'll file a question Issue today and CC you both to get your thoughts. Meantime, thanks again @chriszs for shipping us GA!!

@palewire
Copy link
Contributor

Agreed we need to settle a caching policy. Chris set a smart example here.

@palewire palewire merged commit 3c9e1f9 into biglocalnews:main Jan 21, 2022
@palewire
Copy link
Contributor

We're in. Thank you, @chriszs!

@chriszs chriszs deleted the ga-gh-63-add-scraper branch January 21, 2022 19:41
@chriszs chriszs changed the title feat(ga): add scraper Add GA scraper Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GA scrape
3 participants