STRF-9222 Replace/upgrade deprecated messageformat library

[jairo-bc]

1. Removed disablePluralKeyChecks option as it's not supported anymore
2. "Zero" key is invalid for lang "en". (https://unicode-org.github.io/cldr-staging/charts/latest/supplemental/language_plural_rules.html)
   Before library was ignoring it, now it throws an error. In cornerstone we don't have it (https://github.com/bigcommerce/cornerstone/blob/master/lang/en.json), but other developers might have it.
3. There is change in lang helper logic. Before it was throwing a SyntaxError if there is some "syntax error", now it always a generic Error. So the idea is to throw an error always when the value is invalid and log a message.

cc @bookernath, @bigcommerce/storefront-team

[bookernath]

Before we were returning, and now we're throwing.

Does this mean that on a production store, the page would return an error such as 500, instead of the helper simply failing quietly and returning an empty string?

[bookernath]

Removed disablePluralKeyChecks option as it's not supported anymore

What are the implications of this for real themes?

"Zero" key is invalid for lang "en". (https://unicode-org.github.io/cldr-staging/charts/latest/supplemental/language_plural_rules.html)

Seems okay based on a quick check of our other themes as well. 👍

There is change in lang helper logic. Before it was throwing a SyntaxError if there is some "syntax error", now it always a generic Error. So the idea is to throw an error always when the value is invalid and log a message.

See my comment in the code; I want to make sure we're not causing pages to fail that were not failing before. Changing error/logging syntax is fine, but we shouldn't cause new full-page errors if we can avoid it. Apologies if I misunderstood the code and we're all good :)

[jairo-bc]

@bookernath You were right with your assumption. With that change it was failing on storefront-renderer, but not on GraalVM.
So I made a change to return a function that returns an empty string (like it was before).

[bookernath]

Thanks, LGTM