Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STRF-9091 Modify renderPage operation to take already transformed translations #231

Merged
merged 1 commit into from
Mar 30, 2021
Merged

STRF-9091 Modify renderPage operation to take already transformed translations #231

merged 1 commit into from
Mar 30, 2021

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Mar 26, 2021 •
edited
Loading

cc @bigcommerce/storefront-team

@pachanady
Copy link

@jairo-bc Jairo I think that’s smart, this way you don’t need a new addTranslations function

@jairo-bc
Copy link
Contributor Author

@jairo-bc Jairo I think that’s smart, this way you don’t need a new addTranslations function

yeah, we will have just a simple leverage to decide what to do with translations

@junedkazi junedkazi merged commit af6e235 into bigcommerce:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

@MaxGenash MaxGenash MaxGenash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jairo-bc @pachanady @junedkazi @MaxGenash