Region helper MERC-2432 #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcampa
reviewed
Jun 5, 2017
helpers/location.js
Outdated
| let locationId = params.hash.name; | ||
| let content = ''; | ||
|
|
||
| if ((!paper.renderingContext) || (!paper.renderingContext.locations)) { |
There was a problem hiding this comment.
not sure where you're referring..
There was a problem hiding this comment.
if (!paper.renderingContext || !paper.renderingContext.locations) {
tabayomi
force-pushed
the
location-helper-MERC-2432
branch
4 times, most recently
from
351ef8f
to
5764ebb
Compare
tabayomi
force-pushed
the
location-helper-MERC-2432
branch
from
455148b
to
7b182c2
Compare
2 tasks
|
Merging the changes in this PR together with #118 Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR extends Paper by adding a location helper for content blocks. This enables access inside the helper to using all the available helpers for rendering inside Paper.
Depends on:
#118.
06/14 -- Updated names to Region based on new content service nomenclature