Add helpers for getting sized images from /content and Image Manager #96
Conversation
| const SafeString = require('handlebars').SafeString; | ||
|
|
||
| const factory = globals => { | ||
| return function(path) { |
There was a problem hiding this comment.
I wonder if we should create multiple helpers. Instead should we just pass type as an option which supports pre-defined list like content , image-manager, carousel etc and another flag for src-set as a boolean so we can return data into through a single helper. Thoughts ? cc @mattolson
There was a problem hiding this comment.
these seem like separate enough helpers (that we may even want to evolve independently) that it's nicer to have them separate to me. Just a gut feel.
I could DRY a bit better by making it call the same underlying code with two "modes" for now, though.
There was a problem hiding this comment.
@junedkazi I've extracted the common code into lib to reduce duplication.
bookernath
force-pushed
the
get-cdn-image
branch
from
3eb7b3d
to
5f78b5f
Compare
|
I tested this with stencil-cli to confirm everything works 👍 |
What? Why?
Add new helpers for getting sized versions of assets living in WebDav, either in the
/contentfolder or in the Image Manager folder (/product_images/uploaded_images)There are helpers for both getting individual image URLs, as well as a
srcsetusing the default sizes for the platform.Unlike the existing
getImagehelpers which accept "stencil image" objects, these helpers accept a path to the image in particular object storage folders - so the API is different.How was it tested?
Unit tests added.
cc @bigcommerce/storefront-team