Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: STRF-12234 Make moment.js to warn instead of error #331

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

jairo-bc
Copy link
Contributor

What? Why?

  • Make moment.js to warn instead of error

How was it tested?

npm test
Screenshot 2024-09-25 at 18 25 32
Screenshot 2024-09-25 at 18 26 26


cc @bigcommerce/storefront-team

@jairo-bc jairo-bc requested a review from a team September 26, 2024 11:35
Copy link
Contributor

@bc-max bc-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ngaar ngaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jairo-bc personally, dont think this needs QA since you just changed error to warn. let me know if you think otherwise 🙇

LGTM

@jairo-bc jairo-bc merged commit bd1a333 into master Sep 26, 2024
3 checks passed
Copy link
Contributor

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants