STENCIL-2461 Check if gift certificates are enabled before rendering. #914
Conversation
|
👍 |
| {{> components/cart/gift-certificate-input}} | ||
| </li> | ||
| {{#if settings.gift_certificates_enabled}} | ||
| {{#each cart.gift_certificates}} |
| </div> | ||
| {{> components/cart/gift-certificate-input}} | ||
| </li> | ||
| {{#if settings.gift_certificates_enabled}} |
There was a problem hiding this comment.
You don't need this flag because when gift certificates are disabled cart.gift_certificates should be empty.
if cart.gift_certificates is not empty is because a bcapp bug.
There was a problem hiding this comment.
Plus, If you fix the issue in bcapp, you fix it for all themes
There was a problem hiding this comment.
We still need the check to hide the form element which takes in the gift certificates.
There was a problem hiding this comment.
cart.gift_certificates empty does not mean gift certificates are disabled. It just means no gift certificates are applied to cart.
There was a problem hiding this comment.
No, but if GC are disabled cart.gift_certificates should be empty
|
Checked out and tested locally 💚 |
|
Autotagging @mcampa @bc-miko-ademagic @davidchin |
Only show the gift certificate section if gift certificates are enabled.
@mcampa @mjschock @bigcommerce/stencil-team