Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #1676

Merged
merged 1 commit into from
May 28, 2020

Conversation

rowleyaj
Copy link
Contributor

What?

This was created by running npm install in the root of the repo

node version: 10.17.0
as required by stencil-cli

npm version: 6.11.3

I noticed that there is a section in the README that states that node version 8 and npm version 6.4.1 should be used. Is this accurate since stencil-cli requires node 10? If not I can raise a PR to update this as well.

This was created by running npm install in the root of the repo

node version: 10.17.0
as required by stencil-cli

npm version: 6.11.3
@rowleyaj
Copy link
Contributor Author

@bc-williamkwon tagging you as the last person to update the package.json

let me know if you'd welcome a PR for the README as well

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !!! We really need to fix our release script :)

@junedkazi junedkazi merged commit b3942d5 into bigcommerce:master May 28, 2020
@rowleyaj
Copy link
Contributor Author

rowleyaj commented Jun 5, 2020

@junedkazi if you can provide some direction on what you want I'm happy to help try and improve things with a PR. I'm a BigCommerce customer so have a vested interest in improving how this works.

As a side question - what is the best way to engage with the BigCommerce engineering teams? I'm using this as a BigCommerce customer and at the moment when I raise support issues they're just being closed out as "engineering aware".

Here are just a few examples of support tickets:
Facebook Integration: 04300414404
Error Pages: 04301548 / No issue but told that's normal
Consent Manager Bug Report: 04300075

This last one I got the Jira number for it STRF-7740 and provided a detailed bug report but apparently "this feature is unlikely to be implemented in the short-term." It's not really a feature, it's currently broken.

@rowleyaj rowleyaj deleted the update_package_lock branch June 5, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants