fix(customers): CHECKOUT-4828 Special characters to render properly on the cart modal pop up #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
PascalZajac
requested changes
Apr 19, 2020
There was a problem hiding this comment.
@bookernath partner themes will need to be updated to fix this too, do we do any sort of special comms for that or do they just rely on the changelog?
… the cart modal pop up
junedkazi
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
@PascalZajac for any changes to partner themes we create a THEMES jira and ping @bc-as
PascalZajac
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Due to a recent change input fields on products are sanitised. This means that in cornerstone the expected values weren't rendered as expected
Tickets / Documentation
https://jira.bigcommerce.com/browse/CHECKOUT-4828
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
@bigcommerce/checkout @bigcommerce/storefront-team @abhijethbc