Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cart quantity for bundled items #1596

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fix cart quantity for bundled items #1596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Fix styling of review modal image [#1592](https://github.com/bigcommerce/cornerstone/pull/1592)
- Fix typo in README.md [#1588](https://github.com/bigcommerce/cornerstone/pull/1588)
- Fix corejs warning [#1594](https://github.com/bigcommerce/cornerstone/pull/1594)
- Fix cart quantity calculation for bundled products [#1596](https://github.com/bigcommerce/cornerstone/pull/1596)

## 4.2.1 (2019-10-15)
- Added missing gift certificate translation
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/global/cart-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default function (secureBaseUrl, cartId) {

// Get updated cart quantity from the Cart API
const cartQtyPromise = new Promise((resolve, reject) => {
utils.api.cart.getCartQuantity({ baseUrl: secureBaseUrl }, (err, qty) => {
utils.api.cart.getCartQuantity({ baseUrl: secureBaseUrl, cartId }, (err, qty) => {
if (err) {
reject(err);
}
Expand Down
183 changes: 83 additions & 100 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"license": "MIT",
"dependencies": {
"@babel/polyfill": "^7.4.4",
"@bigcommerce/stencil-utils": "^4.2.0",
"@bigcommerce/stencil-utils": "^5.0.1",
"core-js": "^2.6.10",
"creditcards": "^3.0.1",
"easyzoom": "^2.5.2",
Expand Down