Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storefront): STRF-4418 allow alert text color editing from theme editor and update default alert text color for Bold variation #1565

Merged
merged 1 commit into from
Jan 13, 2020
Merged

feat(storefront): STRF-4418 allow alert text color editing from theme editor and update default alert text color for Bold variation #1565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Allow alert text color editing from theme editor and update default alert text color for Bold variation [#1565](https://github.com/bigcommerce/cornerstone/pull/1565)
- Add jquery-migrate to Modal test [#1599](https://github.com/bigcommerce/cornerstone/pull/1599)
- Upgrade core-js to version 3 [#1598](https://github.com/bigcommerce/cornerstone/pull/1598)

Expand Down
2 changes: 1 addition & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@
"checkRadio-backgroundColor": "#444444",
"checkRadio-borderColor": "#999999",
"alert-backgroundColor": "#444444",
"alert-color": "#ffffff",
"alert-color": "#333333",
"alert-color-alt": "#444444",
"storeName-color": "#ffffff",
"body-bg": "#444444",
Expand Down
5 changes: 5 additions & 0 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
"label": "Alert popup box background",
"id": "alert-backgroundColor"
},
{
"type": "color",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigcommerce/merc-team

"label": "Alert popup text color",
"id": "alert-color"
},
{
"type": "color",
"label": "Horizontal line",
Expand Down