Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nanobar #1537

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Remove nanobar #1537

merged 1 commit into from
Jul 16, 2019

Conversation

bookernath
Copy link
Contributor

What?

This loading bar just makes the site seem slow, removing it.

@bigbot
Copy link

bigbot commented Jul 12, 2019

Autotagging @bigcommerce/storefront-team @davidchin

@bc-williamkwon
Copy link
Contributor

Didn't even know we had nanobar. Seems like a good idea to remove.

Copy link
Contributor

@mattolson mattolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. However, the diff in package-lock is concerning. Can you try with Node 8 and npm 6.4.1?

This loading bar just makes the site seem slow, removing it.
@mattolson mattolson merged commit 0a4f58b into bigcommerce:master Jul 16, 2019
@bookernath bookernath mentioned this pull request Jul 26, 2019
@oggede
Copy link

oggede commented Aug 11, 2019

Just some feedback on this change.

I have a website with a lot of images that have text in them. See here https://www.nameitlabels.com/

As you can see, when you have images with a lot of text, the nanobar is a better option rather than the pre-blured images. When images load on a lower quality, the text is blurred. I have found that the nanobar is more pleasing.

For 95% of people, I'm sure the blurred option is better than the nanobar. However, there are positives and negatives to all systems and changes. One way doesn't always work for everyone.

I recommend leaving the nanobar as an option for people to re-enable or disable.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants