Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cart link not being clickable on mobile when white space reduced around store logo #1296

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Conversation

sacr3dc0w
Copy link
Contributor

What?

When reducing margin around the store logo parent container .header-logo, this can cause an issue on mobile where the logo overlaps the cart link, preventing the ability to click the link. This setting resolves that issue, while also not having any impact on stores that don't reduce the margin around the store logos.

Tickets / Documentation

Screenshots (if appropriate)

Before
01 - before
02 - before

After
03 - after

@bigbot
Copy link

bigbot commented Jun 30, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@junedkazi junedkazi merged commit 5695f34 into bigcommerce:master Jul 2, 2018
@mike-wilson-css mike-wilson-css deleted the header-mobile-logo branch July 2, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants