Avoid undefined context in WishList instance #1247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The value of
this.context
isundefined
within WishList class instance, in the product and account pages. The classconstructor
expects acontext
parameter, but no parameter is provided when the instance is created from "product-details.js" and "account.js".This has no side-effect when no customization is made to the theme. But any customization will expect
this.context
to have thecontext
data, rather thanundefined
.Tickets / Documentation
I have reported it here, but it seems it has been ignored or not understood:
Thank you.