Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid undefined context in WishList instance #1247

Merged
merged 1 commit into from
May 29, 2018
Merged

Avoid undefined context in WishList instance #1247

merged 1 commit into from
May 29, 2018

Conversation

jbruni
Copy link
Contributor

@jbruni jbruni commented May 23, 2018

What?

The value of this.context is undefined within WishList class instance, in the product and account pages. The class constructor expects a context parameter, but no parameter is provided when the instance is created from "product-details.js" and "account.js".

This has no side-effect when no customization is made to the theme. But any customization will expect this.context to have the context data, rather than undefined.

Tickets / Documentation

I have reported it here, but it seems it has been ignored or not understood:

Thank you.

@bigbot
Copy link

bigbot commented May 23, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@jbruni
Copy link
Contributor Author

jbruni commented May 23, 2018

If the issue is difficult to understand, please let me know. I can record a short video showing what is expected, and what happens instead.

@mattolson
Copy link
Contributor

@jbruni Thanks for the bug fix, much appreciated. Can you add a quick entry to the changelog? We'll get this into the next point release.

Copy link
Contributor

@mattolson mattolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, don't worry about it, we'll follow up with a changelog entry. Thanks again.

@mattolson mattolson merged commit 46b0d40 into bigcommerce:master May 29, 2018
Ubersmake added a commit that referenced this pull request May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants