Merge pull request #1654 from bc-krishsenthilraj/ES-466

feat(search): ES-466 Facets with & symbol works now
bigcommerce · Apr 6, 2020 · 3163444 · 3163444
2 parents 7e384a0 + 17e6aa1
commit 3163444
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/templates/components/faceted-search/facets/hierarchy.html b/templates/components/faceted-search/facets/hierarchy.html
@@ -3,7 +3,7 @@
     <div
         class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
         role="button"
-        data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
+        data-collapsible="#facetedSearch-content--{{#replace '&' (hyphenate facet) }}{{/replace}}">
         <h5 class="accordion-title">
             {{ title }}
         </h5>
@@ -21,8 +21,8 @@ <h5 class="accordion-title">
         </div>
     </div>
 
-    <div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
-        <ul id="facetedSearch-navList--{{hyphenate facet }}" class="navList" data-facet="{{facet}}" data-has-more-results="{{ has_more_results }}">
+    <div id="facetedSearch-content--{{#replace '&' (hyphenate facet) }}{{/replace}}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
+        <ul id="facetedSearch-navList--{{#replace '&' (hyphenate facet) }}{{/replace}}" class="navList" data-facet="{{facet}}" data-has-more-results="{{ has_more_results }}">
             {{#each items}}
                 <li class="navList-item">
                     <a
@@ -46,7 +46,7 @@ <h5 class="accordion-title">
         </ul>
 
         {{#if show_more_toggle}}
-            <a href="#facetedSearch-navList--{{hyphenate facet }}" role="button" class="toggleLink">
+            <a href="#facetedSearch-navList--{{#replace '&' (hyphenate facet) }}{{/replace}}" role="button" class="toggleLink">
                 <span class="toggleLink-text toggleLink-text--off">{{lang 'search.faceted.show-more'}}</span>
             </a>
         {{/if}}

diff --git a/templates/components/faceted-search/facets/multi.html b/templates/components/faceted-search/facets/multi.html
@@ -3,7 +3,7 @@
     <div
         class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
         role="button"
-        data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
+        data-collapsible="#facetedSearch-content--{{#replace '&' (hyphenate facet) }}{{/replace}}">
         <h5 class="accordion-title">
             {{ title }}
         </h5>
@@ -21,8 +21,8 @@ <h5 class="accordion-title">
         </div>
     </div>
 
-    <div id="facetedSearch-content--{{hyphenate facet }}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
-        <ul id="facetedSearch-navList--{{hyphenate facet }}" data-facet="{{facet}}" class="navList" data-has-more-results="{{ has_more_results }}">
+    <div id="facetedSearch-content--{{#replace '&' (hyphenate facet) }}{{/replace}}" class="accordion-content {{#unless ../start_collapsed }} is-open {{/unless}}">
+        <ul id="facetedSearch-navList--{{#replace '&' (hyphenate facet) }}{{/replace}}" data-facet="{{facet}}" class="navList" data-has-more-results="{{ has_more_results }}">
             {{#each items}}
                 <li class="navList-item">
                     <a
@@ -46,7 +46,7 @@ <h5 class="accordion-title">
         </ul>
 
         {{#if show_more_toggle}}
-            <a href="#facetedSearch-navList--{{hyphenate facet }}" role="button" class="toggleLink">
+            <a href="#facetedSearch-navList--{{#replace '&' (hyphenate facet) }}{{/replace}}" role="button" class="toggleLink">
                 <span class="toggleLink-text toggleLink-text--off">{{lang 'search.faceted.show-more'}}</span>
             </a>
         {{/if}}

diff --git a/templates/components/faceted-search/show-more-facets.html b/templates/components/faceted-search/show-more-facets.html
@@ -17,7 +17,7 @@ <h1 class="facet-quick-heading">
                         data-id="{{ id }}"
                         data-faceted-search-facet
                         >
-                            {{title}}
+                            {{{title}}}
                             {{#if ../show_product_counts}}
                                 {{#if count}}
                                     <span>({{count}})</span>