Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated product reviews resource to allow updates #107

Closed
wants to merge 1 commit into from

Conversation

iyerushalmi
Copy link

BC API changed and now allows creation/update/deletion of this resource.

BC API changed and now allows creation/update/deletion of this resource.
@pedelman
Copy link
Contributor

@iyerushalmi Thanks for the PR, this is pretty much good to go. Can you also remove the method in the class? def self.all(product_id). This will come for free once it is a sub resource. I didnt even notice this PR and opened #114, much happier to get this one merged if you are comfortable with making that small change and rebasing this PR once #111 is merged.

@pedelman
Copy link
Contributor

This also fixes #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants