-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow implicit options to be passed into product.sku #84
Open
VDuda
wants to merge
6
commits into
bigcommerce:master
Choose a base branch
from
VDuda:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−7
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
af02613
Allow implicit options to be passed into product.sku
VDuda 9063964
Add support for v3
VDuda c802fa8
v3 add support for variants
VDuda c124d74
Add Variants to init
VDuda 01a8307
Added get for variants
VDuda f4ca6e6
Working copy
VDuda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,11 +48,17 @@ def rules(self, id=None): | |
else: | ||
return ProductRules.all(self.id, connection=self._connection) | ||
|
||
def skus(self, id=None): | ||
def skus(self, id=None, **kwargs): | ||
if id: | ||
return ProductSkus.get(self.id, id, connection=self._connection) | ||
return ProductSkus.get(self.id, id, connection=self._connection, **kwargs) | ||
else: | ||
return ProductSkus.all(self.id, connection=self._connection) | ||
return ProductSkus.all(self.id, connection=self._connection, **kwargs) | ||
|
||
def variants(self, id=None, **kwargs): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would prefer to have the V3 products-related endpoints in a completely separate file from the V2 ones - that namespacing will help a lot if we try to apply different logic to them (pagination comes to mind) |
||
if id: | ||
return ProductVariants.get(self.id, id, connection=self._connection, **kwargs) | ||
else: | ||
return ProductVariants.all(self.id, connection=self._connection, **kwargs) | ||
|
||
def videos(self, id=None): | ||
if id: | ||
|
@@ -99,7 +105,9 @@ class ProductImages(ListableApiSubResource, CreateableApiSubResource, | |
count_resource = 'products/images' | ||
|
||
|
||
class ProductOptions(ListableApiSubResource): | ||
class ProductOptions(ListableApiSubResource, CreateableApiSubResource, | ||
UpdateableApiSubResource, DeleteableApiSubResource, | ||
CollectionDeleteableApiSubResource, CountableApiSubResource): | ||
resource_name = 'options' | ||
parent_resource = 'products' | ||
parent_key = 'product_id' | ||
|
@@ -131,6 +139,13 @@ class ProductSkus(ListableApiSubResource, CreateableApiSubResource, | |
parent_key = 'product_id' | ||
count_resource = 'products/skus' | ||
|
||
class ProductVariants(ListableApiSubResource, CreateableApiSubResource, | ||
UpdateableApiSubResource, DeleteableApiSubResource, | ||
CollectionDeleteableApiSubResource, CountableApiSubResource): | ||
resource_name = 'variants' | ||
parent_resource = 'products' | ||
parent_key = 'product_id' | ||
count_resource = 'products/variants' | ||
|
||
class ProductVideos(ListableApiSubResource, CountableApiSubResource, | ||
CreateableApiSubResource, DeleteableApiSubResource, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
from .base import * | ||
|
||
|
||
class Variants(ListableApiResource, CreateableApiSubResource, | ||
UpdateableApiSubResource, DeleteableApiSubResource, | ||
CollectionDeleteableApiSubResource, CountableApiSubResource): | ||
resource_name = 'variants' | ||
parent_resource = 'products' | ||
parent_key = 'product_id' | ||
count_resource = 'products/variants' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VDuda with this bit, the orders API no longer works, as this seems to have an explicit
/v2/
path as per the docs here:https://developer.bigcommerce.com/api-reference/orders/orders-api/orders/getallorders
This bit of the code injects
catalog
in when it is not needed, the url for orders is/store/{store_hash}/v2/orders
Using the code this way would require making a fresh connection for a
v2
connection so we don't break the rest of the API@bookernath am I missing anything with your API endpoints here?