Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require paragonie/random_compat '~1.4|~2.0' #203

Merged
merged 1 commit into from
Jun 5, 2017

Conversation

benlipp
Copy link
Contributor

@benlipp benlipp commented Jun 5, 2017

What?

Allows paragonie/random_compat: ~1.4|~2.0 instead of locking to ~2.0. This is done for compatibility with other packages that require ~1.4. All 2.0 updates are back-ported to 1.4, so this should not cause any issues.

Tickets / Documentation

See the "Version Conflict with [Other PHP Project]" section in the paragonie/random_compat README.

@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage remained the same at 69.153% when pulling 56dbe51 on benlipp:master into 94e5618 on bigcommerce:master.

Copy link
Contributor

@lord2800 lord2800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zvuki let's merge this, it's totally backwards compatible.

@zvuki zvuki merged commit 01a42fe into bigcommerce:master Jun 5, 2017
@benlipp
Copy link
Contributor Author

benlipp commented Jun 5, 2017

Thanks! When is the next release planned?

@lord2800
Copy link
Contributor

lord2800 commented Jun 5, 2017

Good question. @bookernath / @PreciselyAlyss, any thoughts? There's a decent amount of changes sitting in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants