feat(component): auto-highlight first matching option in Select and MultiSelect #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanceaclark
approved these changes
May 10, 2022
bc-andreadao
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Auto highlight first matching option in Select and MultiSelect components.
Why?
Before this feature, the user needed to use the down arrow keyboard in order to select the first matching option, after typing.
Adding this feature is gonna improve the UX. For more context: #783
Screenshots/Screen Recordings
MultiSelect:
Kapture.2022-05-10.at.13.30.47.mp4
Kapture.2022-05-10.at.12.39.16.mp4
Select
Kapture.2022-05-10.at.13.32.37.mp4
Kapture.2022-05-10.at.12.42.22.mp4
Testing/Proof