feat(component): covert Fieldset to FC and remove static members #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Offline review 🕺 |
chanceaclark
force-pushed
the
refactor/fieldset
branch
from
d82814c to
1016daa
Compare
chanceaclark
force-pushed
the
refactor/fieldset
branch
from
1016daa to
a9ace8d
Compare
deini
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fieldsetinstead of it being a static member.Fieldsetcomponent to be a functional component.FieldsetLegendandFieldsetDescription.warning.ts
We know throw an error in console during runtime type checking for the
Fieldsetlegendanddescirptionprops. This ensures the consumer of the component is using the right components when needing to use customlegendanddescriptions's. The implementation ofwarning.tsis a slightly modified version oftiny-warningmodule.BREAKING CHANGE:
Form.Fieldsetrenamed toFieldsetand will now have toimport { Fieldset } from '@bigcommerce/big-design';