feat(component): add hidden headers props to Table and StatefulTable #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtalvarez
approved these changes
Dec 10, 2019
| name: 'hiddenHeaders', | ||
| types: 'boolean', | ||
| defaultValue: 'false', | ||
| description: 'Visually hides the headers.', |
There was a problem hiding this comment.
🤷♀
Suggested change
| description: 'Visually hides the headers.', | |
| description: 'Hides the current tables\'s headers. Headers are only visually hidden to keep with accessibility best practices.', |
| name: 'hiddenHeaders', | ||
| types: 'boolean', | ||
| defaultValue: 'false', | ||
| description: 'Visually hides the headers.', |
There was a problem hiding this comment.
🤷♀
Suggested change
| description: 'Visually hides the headers.', | |
| description: 'Hides the current tables\'s headers. Headers are only visually hidden to keep with accessibility best practices.', |
| @@ -60,6 +60,12 @@ const tableProps: Prop[] = [ | |||
| types: 'boolean', | |||
| description: 'Makes the table header and actions fixed.', | |||
| }, | |||
| { | |||
| name: 'hiddenHeaders', | |||
There was a problem hiding this comment.
What about headerless?
deini
force-pushed
the
feat/table-hidden-headers
branch
from
0bd0c5e to
6b164ec
Compare
deini
force-pushed
the
feat/table-hidden-headers
branch
from
6b164ec to
4a45c96
Compare
chanceaclark
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a boolean
headerlessto<Table />and<StatefulTable />.Headers will be rendered but visually hidden for accessibility purposes.