feat(component): create basic pagination component #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-massingill
requested review from
jorgemoya,
deini,
chanceaclark and
rtalvarez
chanceaclark
reviewed
Sep 4, 2019
There was a problem hiding this comment.
A couple more things:
- Write some unit tests for your new feature.
- You'll need to add a documentation page so you can show how to use your component as well as what props are being passed and how they are useful. See PAGES.md for the structure and layout of the page.
deini
reviewed
Sep 5, 2019
jorgemoya
reviewed
Sep 5, 2019
jordan-massingill
changed the title
chanceaclark
reviewed
Sep 6, 2019
chanceaclark
reviewed
Sep 9, 2019
| } | ||
|
|
||
| setItemRange([firstItemInRange, lastItemInRange]); | ||
| }, [currentPage, currentRange, totalItems]); |
There was a problem hiding this comment.
Correct me if I'm wrong, but if totalItems changes, maxPages will not update. So with that in mind, you'll maybe want to have another useEffect listening to only totalItems and update it whenever that changes.
There was a problem hiding this comment.
Since the state of currentPage is dependent on totalItems and currentRange props, it should/does change dynamically without the need for a useEffect listener (at least, that has been my experience with the component). We may need to look at messing around with this to be certain though.
jordan-massingill
changed the title
added 2 commits
September 11, 2019 14:30
jorgemoya
reviewed
Sep 11, 2019
deini
approved these changes
Sep 16, 2019
chanceaclark
approved these changes
Sep 16, 2019
jorgemoya
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Created Pagination component to be used with lists and tables
TESTING
jest testing
SCREENSHOTS