feat(icons): add flag icons #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemoya
force-pushed
the
icon-falgs
branch
3 times, most recently
from
dede4af to
8e83d06
Compare
jorgemoya
changed the title
chanceaclark
approved these changes
Jan 21, 2021
| @@ -0,0 +1,80 @@ | |||
| const { default: svgr } = require('@svgr/core'); | |||
| // const camelcase = require('camelcase'); | |||
deini
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add flag icons.
How
Added the flag-icon-css library to use their 4x3 SVG icons. Complete list of icons: https://flagicons.lipis.dev/.
Issues
Typescript has two issues with two of the flags, opened two PRs (1, 2) to solve this.
Ping @bigcommerce/frontend
Screenshot
Testing
My initial testing reveals tree shaking is working properly.
Importing icons doesn't return the flags.
I can import a single flag
Or all the flags:
