Remove block-progression from NZ and BO flags #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might want to switch to At the same time, w3schools suggests |
|
I will remove the values then. |
jorgemoya
force-pushed
the
fix-blockprogression-nz
branch
from
ac4f3f4 to
1e96400
Compare
jorgemoya
changed the title
jorgemoya
changed the title
|
@lipis Was wondering if there's any feedback for this and my other PR? |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prefix
block-progressionto-ms-block-progression.Why
I don't know much about this property but seems to be
deprecatedor only used on old IE version. (source, source). I'm using the SVGs inside React + Typescript and I get a type error becauseblock-progressionneeds to be prefixed by-ms-block-progression.I don't even know if we need to keep it, maybe we can remove?