-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metabolomics example #680
base: master
Are you sure you want to change the base?
Metabolomics example #680
Conversation
@mmattano I have done the first review of the proposal, here are a couple of ideas:
|
Changed and added columns
@ypriverol I made some changes to the file to get closer to complying with the testing (I'll edit it more with the next upload) and to incorporate your comments. About them:
|
@@ -0,0 +1,136 @@ | |||
source name characteristics[organism] characteristics[organism part] characteristics[sex] characteristics[biological replicate] characteristics[disease] characteristics[cell type] assay name technology type comment[technical replicate] comment[chromatography instrument] comment[chromatography type] comment[scan polarity] comment[instrument] comment[ion source] comment[data file] comment[metabolite assignment file] comment[fraction identifier] factor value[gene] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmattano I think fraction identifier is extremely strange in metabolomics, meaning fractionation is less frequently than in proteomics. For that reason, I recommend removing that column from the metabolomics SDRF.
@mmattano Can you explain why do you think the following columns are needed for the data, specially targeted metebolomics: chromatography instrument
chromatography type
scan polarity
instrument
ion source
metabolite assignment file
For example, in the proteomics specification we required to provide the instrument but even if MS-based also use LC technologies we don't require to be included in the file because we thought it was not "mandatory" to interpret the data. Is it the case in metabolomics we need the chromatography instrument
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I agree, as discussed in the issue, fractionation is rare, so I'll remove it, I just included potentially interesting columns here to continue the discussion. And you're also right on the chromatography instrument
, that shouldn't be necessary. chromatography type
is very important in my opinion since this directly impacts downstream processing, same as the scan polarity
. Specifying the instrument
is debatable but at least the instrument type should be specified. Similar for the ion source
, although this could be omitted. I would keep the metabolite assignment file
since most types of analysis will make use of one and having this information is critical to recreate the results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmattano @nilshoffmann (also can give input here): For a specification of SDRF metabolomics, we first need to define the requirement columns (which I, sometime, called the minimum information needed to represent the experiment).
In this, PR can try to define what will be the minimum info for the metabolomics dataset. BTW, I do think the sample metadata (characteristics it is the same between both metabolomics and proteomics), the main work should be done in the data site comments.
Added more ontologies
Untargeted metabolomics study
Targeted metabolomics example
Annotation of example studies for metabolics SDRF