Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved document property to config object #34

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

josephmathew900
Copy link
Collaborator

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have verified the functionality in a React application.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

Copy link
Collaborator Author

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soorajbhaskaran _a Please review.

@josephmathew900 josephmathew900 force-pushed the 33-move-document-property-to-config-object branch from 8e7909e to b332365 Compare November 20, 2024 15:43
@josephmathew900 josephmathew900 marked this pull request as ready for review November 20, 2024 15:47
Copy link
Contributor

@soorajbhaskaran soorajbhaskaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soorajbhaskaran soorajbhaskaran merged commit 146dd2d into main Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move externalDocument to userConfig
3 participants