Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to use useHotkeys inside and iframe #23

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Added ability to use useHotkeys inside and iframe #23

merged 3 commits into from
Jul 16, 2024

Conversation

soorajbhaskaran
Copy link
Contributor

@soorajbhaskaran soorajbhaskaran commented Jul 15, 2024 •
edited
Loading

Fixes #22

Description

  • Added a new prop as the 4th argument which can be used to pass the external document object of the iframe
  • Updated the readme with change

Checklist

  • I have made corresponding changes to the documentation.
  • I have verified the functionality in a React application.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers
@soorajbhaskaran _a

@soorajbhaskaran
Copy link
Contributor Author

@josephmathew900 _a: Please review

josephmathew900
josephmathew900 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmathew900 josephmathew900 merged commit 0760fdf into main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to use the "useHotkeys" hook inside an iframe
2 participants
@soorajbhaskaran @josephmathew900