chore: must of been tripping

KSQL does support `<` operator for strings... revert doc change & add test
big-andy-coates · Jan 29, 2020 · acd9f27 · acd9f27
1 parent d9d4b39
commit acd9f27
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 2 deletions.
diff --git a/docs-md/developer-guide/create-a-stream.md b/docs-md/developer-guide/create-a-stream.md
@@ -256,7 +256,7 @@ pages that have a `pageid` value that's less than `Page_20`:
 ```sql
 CREATE STREAM pageviews_intro AS
       SELECT * FROM pageviews
-      WHERE CAST(SUBSTRING(pageid, LEN('Page_') + 1) AS INT) < 20
+      WHERE pageid < 'Page_20'
       EMIT CHANGES;
 ```
 
@@ -306,7 +306,7 @@ Your output should resemble:
 ```
      Query ID               | Kafka Topic     | Query String
 
-     CSAS_PAGEVIEWS_INTRO_0 | PAGEVIEWS_INTRO | CREATE STREAM pageviews_intro AS       SELECT * FROM pageviews       WHERE CAST(SUBSTRING(pageid, LEN('Page_') + 1) AS INT) < 20 EMIT CHANGES;
+     CSAS_PAGEVIEWS_INTRO_0 | PAGEVIEWS_INTRO | CREATE STREAM pageviews_intro AS       SELECT * FROM pageviews       WHERE pageid < 'Page_20' EMIT CHANGES;
 
     For detailed information on a Query run: EXPLAIN <Query ID>;
 ```

diff --git a/ksql-functional-tests/src/test/resources/query-validation-tests/string.json b/ksql-functional-tests/src/test/resources/query-validation-tests/string.json
@@ -0,0 +1,38 @@
+{
+  "tests": [
+    {
+      "name": "< operator",
+      "statements": [
+        "CREATE STREAM INPUT (text STRING) WITH (kafka_topic='test_topic', value_format='DELIMITED');",
+        "CREATE STREAM OUTPUT AS select text, text < 'b2' from INPUT;"
+      ],
+      "inputs": [
+        {"topic": "test_topic", "value": "a1"},
+        {"topic": "test_topic", "value": "b1"},
+        {"topic": "test_topic", "value": "B2"},
+        {"topic": "test_topic", "value": "b2"},
+        {"topic": "test_topic", "value": "b3"},
+        {"topic": "test_topic", "value": "b10"},
+        {"topic": "test_topic", "value": "b01"}
+      ],
+      "outputs": [
+        {"topic": "OUTPUT", "value": "a1,true"},
+        {"topic": "OUTPUT", "value": "b1,true"},
+        {"topic": "OUTPUT", "value": "B2,true"},
+        {"topic": "OUTPUT", "value": "b2,false"},
+        {"topic": "OUTPUT", "value": "b3,false"},
+        {"topic": "OUTPUT", "value": "b10,true"},
+        {"topic": "OUTPUT", "value": "b01,true"}
+      ],
+      "post": {
+        "sources": [
+          {
+            "name": "OUTPUT",
+            "type": "stream",
+            "schema": "`ROWKEY` STRING KEY, `TEXT` STRING, `KSQL_COL_1` BOOLEAN"
+          }
+        ]
+      }
+    }
+  ]
+}