Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: depend on WIN32 package, implement and export hSize #18

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

bfrk
Copy link
Contributor

@bfrk bfrk commented Mar 8, 2023

See the patch comments for details.

@bfrk bfrk force-pushed the master branch 17 times, most recently from a37b795 to d880c62 Compare March 11, 2023 19:14
@bfrk bfrk changed the title WIP use WIN32 package Windows: depend on WIN32 package, implement and export hSize Mar 11, 2023
bfrk added 2 commits March 11, 2023 20:23
WIN32 supports getConsoleScreenBufferInfo since version 2.6.2.0 and
withHandleToHANDLE that supports console handles since 2.13.2.0.

The fallback for Cygwin or MSYS shells now passes the given handle to
the std_in of the "stty size" command. Since size is now implemented as
`hSize stdout`, it works correctly even if stdin is redirected.
@bfrk bfrk marked this pull request as ready for review March 11, 2023 19:33
@supki supki merged commit 9aaaac3 into biegunka:master Mar 13, 2023
@supki
Copy link
Member

supki commented Mar 13, 2023

Thanks, appreciated!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants