Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posix: Fix ioctl foreign import #16

Merged
merged 1 commit into from
Mar 20, 2022
Merged

posix: Fix ioctl foreign import #16

merged 1 commit into from
Mar 20, 2022

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Jun 11, 2021

Previously the type of the request argument of ioctl's
foreign import was incorrect. This can result in incorrect
code generation (and subsequent unsoundness) on some platforms.
Moreover, the import used the ccall calling convention, which can
break in surprising ways on platforms which play tricks with CPP.

Previously the type of the `request` argument of `ioctl`'s
`foreign import` was incorrect. This can result in incorrect
code generation (and subsequent unsoundness) on some platforms.
Moreover, the import used the `ccall` calling convention, which can
break in surprising ways on platforms which play tricks with CPP.
@hasufell
Copy link
Contributor

I can confirm this fixes it for me.

@bgamari
Copy link
Contributor Author

bgamari commented Jun 21, 2021

Pinging @biegunka.

@bgamari
Copy link
Contributor Author

bgamari commented Jul 22, 2021

I have pinged @biegunka via email.

@mrtnpaolo
Copy link

This fixes ghcid on arm macOS.

The wrong $LINES and $COLUMNS returned from the malformed ioctl call make it never refresh the display.

Hope this gets a release 🙏

@hasufell
Copy link
Contributor

hasufell commented Nov 3, 2021

This fixes ghcid on arm macOS.

The wrong $LINES and $COLUMNS returned from the malformed ioctl call make it never refresh the display.

Hope this gets a release 🙏

The NMU was rejected: haskell-infra/hackage-trustees#310

So the only way to make this a release seems to be a package takeover.

@bgamari
Copy link
Contributor Author

bgamari commented Nov 15, 2021

I have sent @supki an email asking about maintainership. If I haven't heard back in two weeks I will start the formal takeover process.

@supki supki merged commit 2b267ba into biegunka:master Mar 20, 2022
@supki
Copy link
Member

supki commented Mar 20, 2022

@bgamari

Hey, thanks for the pull request! I'll gladly make you or anyone else willing a co-maintainer so people don't need to wait when I dissapppear again :)

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 24, 2023
0.3.3
* Fixed ioctl foreign import. (biegunka/terminal-size#16)
* #alignment is a hsc2hs built-in since some unspecified GHC
   7.x. (biegunka/terminal-size#12)
* Captured possible stty stderr output with a
  pipe. (biegunka/terminal-size#13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants