Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use tox-uv to ease lower bound checking, test on Python 3.13 #1109

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Dec 5, 2024

This PR does the following:

  • Adopts tox-uv as a speedup for constructing test environments and automatically calculating minimum versions.
    • This requires setting lower bounds on test dependencies, which is fine. We don't need to be very conservative with these. I just picked some that have worked with other projects I've updated recently and the most recent major versions of some others.
  • Adds the scipy nightly build package index so we'll see breakage coming with plenty of warning. Deferred.
  • Begins testing on 3.13, which is enabled because altair released a new minor version. This cherry-picks @Remi-Gau's [MAINT] support python 3.13 #1093.
  • Some cleanups to coverage. I added tests/ to coverage, even though it's currently only data, so that they'll get picked up if we ever add tests that we don't want installed there.

@effigies
Copy link
Collaborator Author

effigies commented Dec 5, 2024

Well, the good news is that the pre-release tests are now finding nightly packages.

@effigies
Copy link
Collaborator Author

effigies commented Dec 5, 2024

Okay, deferring nightly packages to another PR, because this is already an infrastructure improvement.

I also want to consolidate the package upload step into this workflow, since we're now building it with attestations. I can do that in this PR or another. LMK.

@effigies
Copy link
Collaborator Author

effigies commented Dec 5, 2024

Nevermind. I want to do that one separately as well, and it's orthogonal to this.

This is ready for review.

@effigies effigies force-pushed the py313-uv branch 2 times, most recently from 3a16531 to e4465d9 Compare December 5, 2024 17:13
@effigies
Copy link
Collaborator Author

Following the principle of no objections for 1 week and it still looks good to me, I'm merging.

@effigies effigies merged commit 7a1d744 into bids-standard:master Dec 13, 2024
23 checks passed
@effigies effigies deleted the py313-uv branch December 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants