Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create modality-specific file extension check #745

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

olgn
Copy link
Collaborator

@olgn olgn commented Mar 8, 2019

fixes #704.

Incorporates new file extension check function - bids-validator/utils/files/type.js:file.hasModality. This function is more accurate than the previously implemented bids-validator/utils/files/type.js:file.isDataFile for obtaining modalities from file extensions.

@olgn olgn requested a review from nellh March 8, 2019 23:50
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #745 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   87.05%   87.05%   +<.01%     
==========================================
  Files          75       75              
  Lines        2147     2148       +1     
  Branches      395      395              
==========================================
+ Hits         1869     1870       +1     
  Misses        236      236              
  Partials       42       42
Impacted Files Coverage Δ
bids-validator/utils/summary/collectModalities.js 100% <100%> (ø) ⬆️
bids-validator/utils/type.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a31c8...b3bc937. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #745 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   87.05%   87.05%   +<.01%     
==========================================
  Files          75       75              
  Lines        2147     2148       +1     
  Branches      395      395              
==========================================
+ Hits         1869     1870       +1     
  Misses        236      236              
  Partials       42       42
Impacted Files Coverage Δ
bids-validator/utils/summary/collectModalities.js 100% <100%> (ø) ⬆️
bids-validator/utils/type.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a31c8...bf9bb5a. Read the comment docs.

@olgn olgn merged commit 1024f13 into bids-standard:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files such as /participants are listed in summary as modalities
1 participant