Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the XPCT suffix in microscopy #1973

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

chourroutm
Copy link
Contributor

This PR will ensure the new XPCT suffix for microscopy (see bids-standard/bids-specification#1822 and bids-standard/bids-specification#1646) passes the BIDS validator check.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (318c2f2) to head (169c749).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
+ Coverage   85.68%   86.80%   +1.12%     
==========================================
  Files          91      132      +41     
  Lines        3792     6357    +2565     
  Branches     1220     1525     +305     
==========================================
+ Hits         3249     5518    +2269     
- Misses        457      748     +291     
- Partials       86       91       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

Thanks! I just noticed that we didn't cover .json files in the file-level rules. Could you also update:

https://github.com/bids-standard/bids-validator/blob/6a32b718015eff54c2847eb4915d52e6a05e8c97/bids-validator/bids_validator/rules/file_level_rules.json#L622-L643

@chourroutm chourroutm marked this pull request as ready for review June 17, 2024 09:55
@effigies effigies merged commit 53fdba6 into bids-standard:master Jun 20, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants