Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle CLI entrypoint with main() call #1669

Merged
merged 3 commits into from
May 4, 2023

Conversation

nellh
Copy link
Member

@nellh nellh commented May 3, 2023

This adds a new bids-validator.js build output that can be run with Deno without any additional code. This avoids the need to inject a caller like await main() and lets you run the validator directly from the raw script URL.

I wasn't sure if I should name it bids-validator.js or something more or less descriptive. If you download this file, it's fairly intuitive to run it with this name: deno run ./bids-validator.js

@nellh nellh requested a review from rwblair May 3, 2023 22:15
@nellh nellh added the schema label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (042d943) 83.33% compared to head (b3ea3aa) 83.33%.

❗ Current head b3ea3aa differs from pull request most recent head 0e061f5. Consider uploading reports for the commit 0e061f5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1669   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          92       92           
  Lines        3799     3799           
  Branches     1171     1171           
=======================================
  Hits         3166     3166           
  Misses        535      535           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rwblair rwblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I could think of is putting bids-validator.ts in a bin directory. I could imagine thinking it would be silly to have a directory with a single file in it. I don't know how I feel about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants