Add summary generation to schema-prototype #1481
Conversation
rwblair
changed the title
| @@ -79,7 +93,7 @@ export async function _readFileTree( | |||
| const tree = new FileTreeDeno(relativePath, name, parent, rootPath) | |||
|
|
|||
| for await (const dirEntry of Deno.readDir(join(rootPath, relativePath))) { | |||
| if (dirEntry.isFile) { | |||
| if (dirEntry.isFile || dirEntry.isSymlink) { | |||
There was a problem hiding this comment.
Running locally on an annexed dataset I had to add this to see any files. What kinds of problems could having this cause?
|
@nellh Testing on ds000003 the deno summary matches current summary with the exception of size and datatypes. Current validator will attempt to use filename suffix as a datatype in some cases. For ds003 this means Deno correctly calculates the size where as current valdiator outputs 0. May have something to do with this: https://github.com/bids-standard/bids-validator/pull/1481/files#r912104701 Anything I should add or update? |
At least on the OpenNeuro side, nothing depends on events being listed and I think we should stick to the more spec accurate output here. |
… class instead of singleton. Add additional filenames test
…testing modality ranking in summary
Summary generated is an object literal being exported in src/summary/summary. May be better served as a class. file counts, modalities, and participant metadata seem to be working. Task name is reliant on parsing json files. Right now summaryUpdate code is trying to access the json field in the current context to see if they have a TaskName field.
Also have a some
error: AssertionError: Test case is leaking async ops.to figure out.