Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] add microscopy to modalities in schema #984

Merged
merged 2 commits into from
Jan 27, 2022
Merged

[FIX] add microscopy to modalities in schema #984

merged 2 commits into from
Jan 27, 2022

Conversation

Remi-Gau
Copy link
Collaborator

fixes #983

@Remi-Gau Remi-Gau added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Jan 22, 2022
@codecov
Copy link

codecov bot commented Jan 22, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d611689). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #984   +/-   ##
=========================================
  Coverage          ?   36.16%           
=========================================
  Files             ?        8           
  Lines             ?      788           
  Branches          ?        0           
=========================================
  Hits              ?      285           
  Misses            ?      503           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d611689...17ca52d. Read the comment docs.

tsalo
tsalo approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this.

It looks like micr is already covered in rules/datatypes/micr.yaml and rules/modalities.yaml, so this seems to be the only missing element.

mariehbourget
mariehbourget approved these changes Jan 23, 2022
View reviewed changes
Copy link
Collaborator

@mariehbourget mariehbourget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Remi-Gau for catching and correcting this.
I checked the rest of the schema files and it looks like it was the only thing missing.

@Remi-Gau Remi-Gau merged commit 05c53c3 into bids-standard:master Jan 27, 2022
bids-maintenance added a commit that referenced this pull request Jan 27, 2022
@bids-maintenance
[DOC] Auto-generate changelog entry for PR #984
f544835
@Remi-Gau Remi-Gau deleted the remi-micr_modality_schema branch August 17, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsalo tsalo tsalo approved these changes

@sappelhoff sappelhoff sappelhoff approved these changes

@mariehbourget mariehbourget mariehbourget approved these changes

Assignees
No one assigned
Labels
schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add microscopy to yml for modalities
4 participants
@Remi-Gau @tsalo @sappelhoff @mariehbourget