Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCHEMA] Add TSV column files #827

Merged
merged 45 commits into from
Nov 9, 2021
Merged

[SCHEMA] Add TSV column files #827

merged 45 commits into from
Nov 9, 2021

Commits on Apr 10, 2021

  1. Add template.

    @tsalo
    tsalo committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    84bfd06 View commit details
    Browse the repository at this point in the history

  2. Add first column.

    @tsalo
    tsalo committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    066e2a2 View commit details
    Browse the repository at this point in the history

  3. Add columns.

    @tsalo
    tsalo committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    10816d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. More terms.

    @tsalo
    tsalo committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    19901cd View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Fill name field in all files.

    @tsalo
    tsalo committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    2a48ef6 View commit details
    Browse the repository at this point in the history

  2. More work. 

    Note that there are three very different uses of "name" columns, and two of them are equally common, so I chose not to specify any of them as the "canonical" definition.
    @tsalo
    tsalo committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    2451b9a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Merge branch 'master' into tsv-columns-schema

    @tsalo
    tsalo committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    de00cea View commit details
    Browse the repository at this point in the history

  2. Add remaining definitions.

    @tsalo
    tsalo committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    54458cd View commit details
    Browse the repository at this point in the history

  3. Add macro to render column tables.

    @tsalo
    tsalo committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    b5754e7 View commit details
    Browse the repository at this point in the history

  4. Fix YAML file.

    @tsalo
    tsalo committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    42d6e08 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Consolidate suffixes file.

    @tsalo
    tsalo committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    034c6a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Merge branch 'master' into tsv-columns-schema

    @tsalo
    tsalo committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    b0b2c3f View commit details
    Browse the repository at this point in the history

  2. Remove old individual files.

    @tsalo
    tsalo committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    4988676 View commit details
    Browse the repository at this point in the history

  3. Move columns file.

    @tsalo
    tsalo committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    26e8ae9 View commit details
    Browse the repository at this point in the history

  4. Fix things up a bit.

    @tsalo
    tsalo committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    4615684 View commit details
    Browse the repository at this point in the history

  5. Add columns I missed for modality-agnostic TSV files.

    @tsalo
    tsalo committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    27168f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Support n/a for duration.

    @tsalo
    tsalo committed Oct 6, 2021
    1 Configuration menu
    Copy the full SHA
    de9511a View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Stefan Appelhoff <[email protected]>
    @tsalo @effigies @sappelhoff
    3 people authored Oct 6, 2021
    Configuration menu
    Copy the full SHA
    59aea34 View commit details
    Browse the repository at this point in the history

  3. Code formatting in stim_file definition.

    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    a1148c0 View commit details
    Browse the repository at this point in the history

  4. Allow numbers and strings for value.

    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    02568cf View commit details
    Browse the repository at this point in the history

  5. Update src/schema/objects/columns.yaml 

    Co-authored-by: Stefan Appelhoff <[email protected]>
    @tsalo @sappelhoff
    tsalo and sappelhoff authored Oct 6, 2021
    Configuration menu
    Copy the full SHA
    c3f2558 View commit details
    Browse the repository at this point in the history

  6. Allow n/a for "z" column. 

    Addresses https://github.com/bids-standard/bids-specification/pull/827/files#r723280787.
    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    dc227d6 View commit details
    Browse the repository at this point in the history

  7. Describe meanings of x, y, and z columns. 

    Addresses https://github.com/bids-standard/bids-specification/pull/827/files#r723283314.
    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    d831c6c View commit details
    Browse the repository at this point in the history

  8. Allow n/a for status column. 

    Addresses https://github.com/bids-standard/bids-specification/pull/827/files#r723269382.
    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    3955ed4 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'tsv-columns-schema' of https://github.com/tsalo/bids-sp… 

    …ecification into tsv-columns-schema
    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    9b4e8b9 View commit details
    Browse the repository at this point in the history

  10. Add participant_id to participants.tsv table and append info for othe… 

    …r IDs.
    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    0cb74ee View commit details
    Browse the repository at this point in the history

  11. Split type definitions into channels and electrodes versions.

    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    8d39711 View commit details
    Browse the repository at this point in the history

  12. Update definitions for group based on file type.

    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    e7db250 View commit details
    Browse the repository at this point in the history

  13. Split reference column definition.

    @tsalo
    tsalo committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    3218e8e View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Clean up name_channels definition.

    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    3918690 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Draft new columns from bids-standard#816

    @tsalo
    tsalo committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    552b4ae View commit details
    Browse the repository at this point in the history

  2. Add new columns to table.

    @tsalo
    tsalo committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    84241d4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into tsv-columns-schema

    @tsalo
    tsalo committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    bd8c933 View commit details
    Browse the repository at this point in the history

  4. Remove list items.

    @tsalo
    tsalo committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    9161079 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Update src/04-modality-specific-files/04-intracranial-electroencephal… 

    …ography.md

Co-authored-by: Stefan Appelhoff <[email protected]>
    @tsalo @sappelhoff
    tsalo and sappelhoff authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a7356eb View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Chris Markiewicz <[email protected]>
    @tsalo @effigies
    tsalo and effigies authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    fd54609 View commit details
    Browse the repository at this point in the history

  3. Use two underscores to delineate multiply-defined columns.

    @tsalo
    tsalo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    efa6fa1 View commit details
    Browse the repository at this point in the history

  4. Remove text that is now in table.

    @tsalo
    tsalo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    0a4880f View commit details
    Browse the repository at this point in the history

  5. Update src/schema/objects/columns.yaml 

    Co-authored-by: Chris Markiewicz <[email protected]>
    @tsalo @effigies
    tsalo and effigies authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    48656fc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'tsv-columns-schema' of https://github.com/tsalo/bids-sp… 

    …ecification into tsv-columns-schema
    @tsalo
    tsalo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    7ff360a View commit details
    Browse the repository at this point in the history

  7. Add sections to README on columns file and on reused terms.

    @tsalo
    tsalo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    de5b5f6 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into tsv-columns-schema

    @tsalo
    tsalo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    ba84f44 View commit details
    Browse the repository at this point in the history

  9. Add EDF info to acq_time definition.

    @tsalo
    tsalo committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    4ba9c25 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Remove hardcoded tables.

    @tsalo
    tsalo committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    b510b7d View commit details
    Browse the repository at this point in the history

  2. Remove unused links.

    @tsalo
    tsalo committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    d562986 View commit details
    Browse the repository at this point in the history