-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] BEP030: Functional Near-Infrared Spectroscopy #802
Merged
Merged
Changes from 107 commits
Commits
Show all changes
110 commits
Select commit
Hold shift + click to select a range
6b5b218
Add fNIRS
rob-luke c8712f6
Rename
rob-luke f25e11f
Review
rob-luke 9ea41aa
Review
rob-luke ac458b5
Use macros
rob-luke ec0c9c3
Update metadata.yaml
rob-luke 9d493ee
Update 11-functional-near-infrared-spectroscopy.md
rob-luke 5aea159
Update columns.yaml
rob-luke b1e70ea
Update columns.yaml
rob-luke f3ef8c9
Update metadata.yaml
rob-luke b35cfe3
Use master schemacode
rob-luke 11c7071
Revert "Use master schemacode"
rob-luke d109049
Merge branch 'master' into bep030
sappelhoff a6a7d41
SCHEMA: Update datatype rules to be named, have datatypes key
effigies 5523bda
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 1933ef5
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 3954a71
Update src/schema/objects/columns.yaml
rob-luke a94b3c2
Update src/schema/objects/columns.yaml
rob-luke 31c0f45
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 9877469
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 9a903f3
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke dd91b62
Update src/schema/objects/columns.yaml
rob-luke a78574a
Update src/schema/objects/columns.yaml
rob-luke c64bc52
Update src/schema/objects/columns.yaml
rob-luke 6190458
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 0c160f9
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 57f5209
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke c8ec341
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 16f3503
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 948cd70
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke fc881f4
Fix missing info in render
rob-luke 8a37810
Fix missing rules for type in nirs
rob-luke 2790e3f
Add acquisition
rob-luke 6410775
Remove acquisition from photo
rob-luke e8a9d14
Merge remote-tracking branch 'upstream/master' into bep030
effigies c19e35b
add SPEC_ROOT prefix to links from schema to internal spec
sappelhoff 57d4081
Merge branch 'master' into bep030
rwblair 751273a
add sidecar and check rules for nirs
rwblair e5b79a3
Merge branch 'master' of github.com:bids-standard/bids-specification …
rwblair 3623be5
misisng : in context.yaml
rwblair 0bf2deb
yamllint fixes
rwblair 66c021f
add level adendum for recommended descriptions
rwblair d571848
harmonize objects and rules
rwblair 23e728d
we must appease the linting gods
rwblair 35290d4
add missing display_name fields in objects. I am wildly inconsistent …
rwblair 4e851de
change links to point at md not html in schema objects
rwblair 6481c79
associations should be a suffix, can't nest them like I tried for nirs
rwblair 3e6b52f
add coordsystem to associations, adjust rules accordingly
rwblair 8a91620
Update src/schema/rules/datatypes/nirs.yaml
rwblair 7143b0f
Update src/schema/rules/datatypes/nirs.yaml
rwblair 947183a
Update src/schema/rules/sidecars/nirs.yaml
rwblair 1dbc7ca
Update src/schema/rules/sidecars/nirs.yaml
rwblair ff347bf
Merge branch 'master' of github.com:bids-standard/bids-specification …
rwblair 96478d5
Update src/schema/objects/metadata.yaml
rwblair 28796af
Update src/schema/objects/metadata.yaml
rwblair 3b28c22
detector__optoedes --> detector_type
rwblair 172be76
SourceType format set to be just string
rwblair 381828f
Add make_sidecar_table macros alongside old style tables to compare f…
rwblair ac75f5c
Merge branch 'bep030' of github.com:bids-standard/bids-specification …
rwblair 9d4ba9c
correct mislabeled addendums
rwblair bcfe6ad
uncapitalize requirement level
rwblair 9ebae61
add missing _ to make sidecar table macro, and fix spelling
rwblair be3daad
update coordsystem.json tables to use rules/sidecars/nirs entries.
rwblair 031b9aa
fix typos in schema
sappelhoff 3299fd9
Update src/schema/rules/checks/nirs.yaml
rwblair d2d4b80
Update src/schema/rules/checks/nirs.yaml
rwblair 736a49e
Update src/schema/rules/checks/nirs.yaml
rwblair 4e4c722
add nirs to common principles schema object
rwblair 36202ca
no space in infra red even if for an acronym
rwblair 638c11a
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 991d7df
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke ad74ef2
Implement cap description changes
rob-luke e678b15
Improvements to cap description fields
rob-luke cdbc04f
Move age details to modality agnostic page
rob-luke 9b1ae4e
Update src/04-modality-specific-files/11-functional-near-infrared-spe…
rob-luke 5aa31e0
Lint
rob-luke 9abdb4d
Merge branch 'master' into bep030
sappelhoff 4090a74
Update README.md
sappelhoff 51d2b27
Merge branch 'master' into bep030
sappelhoff 0cda6c6
Merge remote-tracking branch 'upstream/master' into bep030
effigies f9008e7
Make aux channel counts optional
rob-luke 160bf12
Update metadata.yaml
rob-luke c110a93
apply small wording and typo fixes
sappelhoff 07e28cb
Merge branch 'master' into bep030
sappelhoff 024fbc4
add citation placeholder NIRS
sappelhoff 66a04c2
Update src/schema/objects/metadata.yaml
sappelhoff 5bbd39a
fix appendix links
sappelhoff 69a2db3
Merge branch 'bep030' of https://github.com/bids-standard/bids-specif…
sappelhoff ca9550a
Update README.md
rob-luke f23adb7
Revert redundant NIRS age column suggestion
rob-luke d8238bb
Add link to coordinate system appendix
rob-luke 4fdec60
Clarify relation between rows in channels.tsv and NIRSChannelCount
rob-luke 3d957e3
Change NIRSCoordinateProcessingDescription example from none to n/a
rob-luke 2481a59
Update src/schema/meta/context.yaml
rob-luke e93e10e
Try and fix path bug
rob-luke 1bb288d
Still trying to fix appendix path bug
rob-luke 6489d40
Still trying to get path working
rob-luke e7d652a
Path bug
rob-luke cda994f
Update src/schema/rules/checks/nirs.yaml
rob-luke cc35e17
Step one of adding IntendedFor
rob-luke 435a8f6
Step two of adding IntendedFor
rob-luke 3cb7e88
Step three of adding IntendedFor
rob-luke 696d3b2
Revert naming change
rob-luke dcbfb9a
Move cap fields to recommended
rob-luke e600e69
update documentation regarding cap manufacturing. (#1285)
helenacockx f624497
Merge remote-tracking branch 'upstream/master' into bep030
effigies 3ce06ae
SCHEMA: Sync table definitions, render from schema
effigies 7e65f3a
SCHEMA: Update schema rules, including *ChannelCount checks
effigies 501d3e8
Channels is recommended. Optodes is required if channels is present.
rob-luke fa5a56f
Variable naming changes suggested by tsalo
rob-luke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
295 changes: 295 additions & 0 deletions
295
src/04-modality-specific-files/11-functional-near-infrared-spectroscopy.md
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be NIRS, I think -- because the suffix is NIRS and in the validator it's also NIRS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIRS is the method, but it has much broader uses such as food and atmospheric chemistry (e.g. scanning fruit for quality issues). When applied to neuroimaging we use fNIRS. So I think this should remain fNIRS. I also re-read the main md file, and we consistently use fNIRS (and I think this sounds correct). The coding and validator uses nirs. Is this a big issue? If it is a big issue, and we want to remove the "functional" from everywhere, I would want to get approval from @lpollonini first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer it to be consistently fNIRS then ... not sure if worth the effort though 🤔 WDYT @rwblair @effigies @tsalo @Remi-Gau ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AS @rob-luke said, NIRS has a variety of non-functional and/or non-brain applications (e.g., optical mammography), and the SNIRF extension (which somehow guided the design of this BEP) was crafted with a wide scope to keep those in mind.
Practically, I not clearly see this BEP being widely adopted outside of neuroimaging, i.e. functional NIRS., so I would be in favor of using the narrower, yet best-fitting "fNIRS" everywhere.
On the other hand, I am not opposed to leave it as NIRS in consistency with MRI (as opposed to fMRI) naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This echoes my opinion. And we do use a NIRS measurement to perform fNIRS neuroimaging, so I don't think anything is technically incorrect. I am eager to hear the opinions of others on this, thanks for the detailed review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also in favor of using NIRS instead of fNIRS. There are for example also researchers that use NIRS to study orthostatic hypotension in the brain. They use the same devices as we do, so could benefit from the BEP, but are technically not interested in the 'functional' part of fNIRS. (see this study for example)