Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Updated TotalAcquiredVolumes into TotalAcquiredPairs #742

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

effigies
Copy link
Collaborator

TotalAcquiredVolumes became TotalAcquiredPairs with the following changes:

  • required: it appears that this should be required as it is crucial information for quantitative analysis
  • small changes in description

TotalAcquiredVolumes became TotalAcquiredPairs with the following changes:
- required: it appears that this should be required as it is crucial information for quantitative analysis
- small changes in description
changed array of numbers into number
@effigies effigies mentioned this pull request Feb 23, 2021
Copy link
Collaborator Author

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patsycle @HenkMutsaerts This looks good to me. Thanks for your diligence in working through all these issues before release.

@franklin-feingold franklin-feingold merged commit 9b22cad into master Feb 23, 2021
effigies added a commit to bids-standard/legacy-validator that referenced this pull request Feb 23, 2021
@sappelhoff sappelhoff deleted the bep-005 branch March 30, 2021 09:24
@sappelhoff sappelhoff changed the title Updated TotalAcquiredVolumes into TotalAcquiredPairs [MISC] Updated TotalAcquiredVolumes into TotalAcquiredPairs May 7, 2021
rob-luke pushed a commit to rob-luke/bids-validator that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants