[FIX] Add deprecated anatomical MRI suffixes back into schema #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
added
the
schema
|
Do these have an impact on rendering anywhere? |
|
Other than the entity table, no they shouldn't. The filename patterns will just generalize any patterns with more than 4 (I think) suffixes to just |
sappelhoff
reviewed
Feb 9, 2021
effigies
approved these changes
Feb 9, 2021
sappelhoff
approved these changes
Feb 10, 2021
|
Thanks 👍 |
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None. Stems from https://github.com/bids-standard/bids-validator/pull/1161#discussion_r572940783 by @effigies.
Changes proposed:
T2star,PD, andFLASHsuffixes back into the schema.anat.ymlto match the variable names in the validator.