Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Allow encoding the fieldmapping intent of the protocol #622
[ENH] Allow encoding the fieldmapping intent of the protocol #622
Changes from 5 commits
c44b926
1aec168
9664f8f
5be9e5f
702d8b9
8377588
8d862e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In link with comment by @tsalo, it seems it used as prefix in this PR the fieldmap type as defined in section Fieldmap data (current line 607), so should not we use of
epi_fmap0
instead ofpepolar_fmap0
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, the idea for these identifiers is that they must be unique within-subject. There's really no difference between
epi_fmap0
andpepolar_fmap0
. Howeverepi_fmap0
could confuse some user that a valid raw suffix is necessary. I'm going to change that in line 692.