-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Allow fractional seconds in scans file datetimes #470
Changes from 2 commits
7c291df
2bdd685
b2566f6
bb7bec3
042ca11
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -264,15 +264,16 @@ imaging acquisition sequence (each run `.nii[.gz]` file) within one session. | |
Each `.nii[.gz]` file should be described by at most one row. Relative paths to | ||
files should be used under a compulsory `filename` header. If acquisition time | ||
is included it should be under `acq_time` header. Datetime should be expressed | ||
in the following format `2009-06-15T13:45:30` (year, month, day, hour (24h), | ||
minute, second; this is equivalent to the RFC3339 "date-time" format, time zone | ||
is always assumed as local time). For anonymization purposes all dates within | ||
one subject should be shifted by a randomly chosen (but common across all runs | ||
etc.) number of days. This way relative timing would be preserved, but chances | ||
of identifying a person based on the date and time of their scan would be | ||
decreased. Dates that are shifted for anonymization purposes should be set to a | ||
year 1925 or earlier to clearly distinguish them from unmodified data. Shifting | ||
dates is RECOMMENDED, but not required. | ||
in the following format `2009-06-15T13:45:30[.000000]` (year, month, day, | ||
hour [24h], minute, second, and optionally fractional second; this is | ||
equivalent to the RFC3339 "date-time" format, time zone is always assumed as | ||
local time). For anonymization purposes all dates within one subject should be | ||
shifted by a randomly chosen (but common across all runs etc.) number of days. | ||
This way relative timing would be preserved, but chances of identifying a | ||
person based on the date and time of their scan would be decreased. Dates that | ||
are shifted for anonymization purposes should be set to a year 1925 or earlier | ||
to clearly distinguish them from unmodified data. Shifting dates is | ||
RECOMMENDED, but not required. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can I be annoying and ask that you move each new sentence to a new line? This is a good example of a small change that forces the entire paragraph to be in the diff because we don't break at sentence boundaries. If we're going to have a big diff, why not make it one that helps us have smaller diffs in the future? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be good now. |
||
|
||
Additional fields can include external behavioral measures relevant to the | ||
scan. For example vigilance questionnaire score administered after a resting | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we here or somewhere state that the number of fractional digits is up to the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of "No specific precision is required for fractional seconds, but the precision should be consistent across the dataset"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with a capital SHOULD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.