-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix typos and formatting #404
[FIX] Fix typos and formatting #404
Conversation
Suggestions for diffusion should be submitted to https://github.com/bids-standard/bids-bep016. Suggestions for common-derivatives should be made against the Regarding "grey" vs "gray". We don't use either in the current standard, so there's no local precedent. Gray is consistent with NIfTI-1 and GIFTI. CIFTI-2 uses "gray" in text and "grey" in the constants I'm okay with moving fully to gray. |
Thanks for the PR. I am also +1 on adopting US spelling convention, because it would be keeping the current convention in the spec. We use:
Etc. so gray isntead of grey makes sense to me. |
@effigies could we just change the target of this PR to Or should @alexandreroutier first revert his changes to @alexandreroutier if you have some time and are faster than @effigies to respond, you could also adhere to his advice and simply make:
|
Sorry about the delay... Because some of the files are not in common-derivatives, simply changing the target branch won't work. |
That said, I can just change to "gray" for common-derivatives, merge it into |
cool. @alexandreroutier for simplicity, please revert changes to src/05-derivatives/06-diffusion-derivatives.md here. Then we can merge this. Afterwards, you are most welcome to make a PR with your changes from src/05-derivatives/06-diffusion-derivatives.md to https://github.com/bids-standard/bids-bep016 |
I updated derivatives and then merged in here. I think this is ready for review. |
Thanks @alexandreroutier |
Hello,
I found very small typos/formatting issues. Also, Gray/Grey names were both present. I used US convention to harmonize this.
Best,
Alexandre