Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation check for ElektaNeuromagMEGIN in schema #1848

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add deprecation check for ElektaNeuromagMEGIN in schema #1848

merged 1 commit into from
Jun 20, 2024

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Jun 6, 2024
@sappelhoff sappelhoff requested a review from effigies June 6, 2024 07:30
@sappelhoff sappelhoff mentioned this pull request Jun 6, 2024
Merged
effigies
effigies approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @rwblair Does this look sensible to you?

@sappelhoff sappelhoff added this to the 1.10.0 milestone Jun 6, 2024
@sappelhoff sappelhoff requested a review from rwblair June 19, 2024 14:08
@rwblair rwblair merged commit db6b07d into bids-standard:master Jun 20, 2024
24 of 26 checks passed
@sappelhoff sappelhoff deleted the schema/meg branch June 21, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@rwblair rwblair rwblair approved these changes

@tsalo tsalo Awaiting requested review from tsalo

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

Assignees
No one assigned
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sappelhoff @effigies @rwblair