Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIDS 2.0: harmonize TSV columns to be singular (ATM "units" and "migrate_plural_columns") #1821

Draft
wants to merge 3 commits into
base: bids-2.0
Choose a base branch
from
Draft

BIDS 2.0: harmonize TSV columns to be singular (ATM "units" and "migrate_plural_columns") #1821

wants to merge 3 commits into from

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented May 15, 2024 •
edited
Loading

Closes

TODOs

  • review if any other renames are due (not necessarily plural -> singular but might be done along here)
  • decide on either renaming "units" to "unit" is worthwhile given that there is lots of "*Units" in sidecar fields: MINOR: Replace "units" with "unit" in channels.tsv bids-2-devel#15 (comment)
  • RECOMMEND for the user added columns to be singular
    • consider possibility for adding a check to bids-validator -- might be too tricky to be worth it since not trivial to determine plurality AFAIK
  • compliment with changes to "CONTRIBUTION" guide of some kind (@effigies please remind where should we place those)
    • add a test for schema tests to ensure that nobody inadvertently adds another plural column
      • might be worth for BIDS 1.0 with whitelisting of known 2 culprits so we prevent possibly adding more
  • implement migration code

@yarikoptic yarikoptic mentioned this pull request May 15, 2024
Draft
14 tasks
@yarikoptic
[DATALAD RUNCMD] Rename hplc_recovery_fractions to hplc_recovery_frac…
f9a2ae3 
…tion

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi hplc_recovery_fractions hplc_recovery_fraction",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsalo tsalo Awaiting requested review from tsalo tsalo will be requested when the pull request is marked ready for review tsalo is a code owner

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca will be requested when the pull request is marked ready for review erdalkaraca is a code owner

@DimitriPapadopoulos DimitriPapadopoulos Awaiting requested review from DimitriPapadopoulos DimitriPapadopoulos will be requested when the pull request is marked ready for review DimitriPapadopoulos is a code owner

Assignees
No one assigned
Labels
bids-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yarikoptic