REL: v1.2.0 #161
Merged
REL: v1.2.0 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklin-feingold
approved these changes
Feb 25, 2019
sappelhoff
approved these changes
Feb 25, 2019
|
Commented and then decided against it. Congratulations on the next release. |
|
@chrisfilo once this release is done, could you also make a release of the |
|
Yes. That's the plan!
…On Sat, Mar 2, 2019, 12:27 AM Stefan Appelhoff ***@***.***> wrote:
@chrisfilo <https://github.com/chrisfilo> once this release is done,
could you also make a release of the bids-validator so that EEG/iEEG work
out of the box?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOkp4tVpjE-LB7LZAu_dhFoIQBg_jc4ks5vSjYCgaJpZM4bQQjO>
.
|
|
According to the rules this could be merged now. Are we waiting for something @chrisfilo ? |
sappelhoff
added
the
exclude-from-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After months of reviews, EEG and iEEG support was merged. This seems like a good time to release.