Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Adds Kim Ray as maintainer. #1571

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

arokem
Copy link
Collaborator

@arokem arokem commented Aug 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d6e77f1) 87.83% compared to head (3ee7ad4) 87.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1571   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the spacing's wonky, which I would expect to raise an error since we build the docs with mkdocs in strict mode, but since CI is passing I guess it's no longer an issue.

@effigies
Copy link
Collaborator

effigies commented Aug 3, 2023

This file isn't part of the mkdocs build. Could fix up the spacing.

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Aug 3, 2023

Need an update of the bids website too

sappelhoff added a commit to bids-standard/bids-website that referenced this pull request Aug 3, 2023
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Aug 3, 2023

@sappelhoff AKA the 📸

@effigies effigies merged commit d3906e2 into bids-standard:master Aug 3, 2023
19 checks passed
@sappelhoff sappelhoff changed the title Adds Kim Ray as maintainer. [INFRA] Adds Kim Ray as maintainer. Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants