[FIX] clarify TriggerChannelCount and TRIG type #1342
Conversation
sappelhoff
requested review from
tsalo,
erdalkaraca and
ezemikulan
as code owners
| name type units description sampling_frequency low_cutoff high_cutoff notch software_filters status | ||
| UDIO001 TRIG V analogue trigger 1200 0.1 300 0 n/a good | ||
| MLC11 MEGGRADAXIAL T sensor 1st-order grad 1200 0 n/a 50 SSS bad | ||
| ``` |
There was a problem hiding this comment.
I removed this example, because a channels.tsv example is already present below the channel types table
| | EOG | Generic EOG channel | | ||
| | ECG | ElectroCardioGram (heart) | | ||
| | EMG | ElectroMyoGram (muscle) | | ||
| | TRIG | Analog (in volt) or digital (TTL bit level) trigger channel | |
There was a problem hiding this comment.
The "TTL" convention applies to both the analog representation as the binary interpretation. Even in memory of a computer a bit is still represented as a voltage.
I suggest to write "Analog (TTL in Volt) or digital (binary TTL) trigger channel".
There was a problem hiding this comment.
oh, and I would not write "bit level", as that suggests that every bit is to be represented in a separate channel. Some systems do that (like Neuromag, only for backward compatibility), but it is not so common. Most represent the bits jointly in a single numeric value.
There was a problem hiding this comment.
thanks! implemented in eaa0dfb
Codecov ReportBase: 88.39% // Head: 88.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1342 +/- ##
=======================================
Coverage 88.39% 88.39%
=======================================
Files 11 11
Lines 1086 1086
=======================================
Hits 960 960
Misses 126 126 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
closes #1318
would this be what you had in mind @robertoostenveld @ftadel @teonbrooks ?